netty: Swap to UniformStreamByteDistributor#11954
Merged
shivaspeaks merged 2 commits intogrpc:masterfrom Mar 11, 2025
Merged
Conversation
shivaspeaks
requested review from
AgraVator,
ejona86,
kannanjgithub and
larry-safran
ejona86
approved these changes
Mar 11, 2025
| Http2FrameWriter frameWriter = new DefaultHttp2FrameWriter(encoder); | ||
| Http2Connection connection = new DefaultHttp2Connection(false); | ||
| WeightedFairQueueByteDistributor dist = new WeightedFairQueueByteDistributor(connection); | ||
| dist.allocationQuantum(16 * 1024); // Make benchmarks fast again. |
Member
There was a problem hiding this comment.
The "Make benchmarks fast again" might want to be preserved in some way. Basically, it is saying, "changing the default for performance."
Member
Author
There was a problem hiding this comment.
How about "// Tuned for better benchmarks performance."?
Member
There was a problem hiding this comment.
"Tuned" may be misleading as to exactly how much thought went into the value. How about just "Increased"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11659
FYI: netty/netty#14918